-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add testing documentation #4884
Conversation
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
While you are waiting, make sure to:
Learn more about: |
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Just want to share something when writing e2e tests. When I try to run my new e2e tests locally, the setup command ("go test -v -tags e2e ./utils/setup_test.go") deployed the official KEDA image, which is not convenient for debugging new tests with a changed KEDA. I suggest adding a parameter in the setup command for deploying the custom image repository so that developers can use their KEDA repository for debugging. |
It's already supported but not properly documented I think. As KEDA is deployed using make, and Makefile uses variables, you can set those envs (globally o for the command) and that's all. |
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@SpiritZhou @zroubalik PTAL |
It looks great now! |
/skip-e2e |
lol, although I requested a revision of @zroubalik , looks like GH already took into account the previous approval and the automerger did its job. I guess that I had to dismiss the approval instead or request another review :/ |
* Add testing strategy document Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Update TESTING.md Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Update TESTING.md Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * add extra info to tests Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> --------- Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Yoon Park <yoongon.park@gmail.com>
* Add testing strategy document Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Update TESTING.md Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Update TESTING.md Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * add extra info to tests Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> --------- Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
* Add testing strategy document Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Update TESTING.md Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Update TESTING.md Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * add extra info to tests Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> --------- Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: anton.lysina <alysina@gmail.com>
I have ported the documentation that we provided during graduation DD to the repository in order to make it publicly accessible and easy to find
Checklist
Fixes #4173